MAINT: split bootstrap and theme styling

[12rambau]

Fix #142

I actually need help on this one.

What I did:

• create 2 entry points for our webpack file so that bootstrap and pydata-sphinx-theme are both in separate files.
• improve the code of the webpack file
• remove import to bootstrap in the former "index.js"
• remove bootstrap code from "index.js"

My problem:

• do we need all the bootstrap variables in the pydata-sphinx-theme.scss ?
• why is the bootstrap.css no available in the readthedoc build when it works just fine on my local build ?

If anyone is ready to give me a hand that would be much appreciated

[choldgraf]

This looks like a great start to me - I agree it will be easier to reason with the CSS and JS if we separate the two cleanly. One comment and two quick answers to your questions:

do we need all the bootstrap variables in the pydata-sphinx-theme.scss ?

Almost certainly not, but I don't think we need to block this PR on that decision as it might be complex to figure out. I'm fine w/ doing that in a follow-up.

why is the bootstrap.css no available in the readthedoc build when it works just fine on my local build ?

I wonder if it's because we aren't packaging the bootstrap JS and CSS with the theme? I believe we do some configuration of static assets with sphinx-theme-builder here:

pydata-sphinx-theme/pyproject.toml

Lines 8 to 11 in d99811d

	additional-compiled-static-assets = [
	"webpack-macros.html",
	"vendor/",
	]

So maybe that needs to be modified to tell it to include the bootstrap JS/CSS as well? (I think it automatically picks up the pydata-sphinx-theme.css file because of the configuration in theme.conf.

One way to test this locally is to make sure you're not installing the theme in editable mode - make sure you're installing the package in the same way any other person would install from pypi...sometimes that helps clarify issues due to packaging mistakes

[12rambau]

So maybe that needs to be modified to tell it to include the bootstrap JS/CSS as well? (I think it automatically picks up the pydata-sphinx-theme.css file because of the configuration in theme.conf.

nice catch I needed to add the bootstrap .js and .css

[choldgraf]

This generally looks pretty good to me! The demo on RTD looks to be styled correctly too. A few minor comments in there. @12rambau anything else you are looking to do here?

[12rambau]

anything else you are looking to do here?

@choldgraf, nope it's waiting to be merged

[choldgraf]

I think once the merge conflict is fixed we are good to go 👍

[choldgraf]

woot - many thanks @12rambau :-)