-
Notifications
You must be signed in to change notification settings - Fork 339
MAINT: Upgrade FontAwesome dependency to latest version #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Won't this break many of the existing class names? If I recall, their css structure change right? Eg it went from I think it's a good idea in general to keep up to date with these icon packs, but we should figure out how disruptive of a change it would be. |
I've checked in their docs, and there is backwards compatibility for style names https://fontawesome.com/docs/web/setup/upgrade/whats-changed#full-style-names |
I'd vote that we wait on this until after the 0.10 release. probably nothing will break, but to me the gain seems pretty minimal, so that it's not worth the risk of needing to scramble to fix things if something does break. |
As we are relying on version 5, some projects maybe still use version 4 (backward compatible). Apart from finding a way to notify the users about this change I think we should follow what is done in sphinx-design (as they have all the icon-related directives) and only update the version once they do. what do you think? |
Agreed it makes sense to hold off to 0.11 👍 Note that I don't think that this one will break anything as-is, because it doesn't actually change any of our CSS classes, it just loads the latest FontAwesome, and since it is backwards-compatible with both v4 and v5 I don't think it'd disrupt anything right? I think the path of least resistance here would be:
|
|
This is a PR to propose an upgrade to the latest version of FontAwesome (i.e. v6.1.2). Moving from 5.13.0 to 6.x.x provides to
pydata-sphinx-theme
users with a richer bank of icons, and also more up to date versions of brand logos (e.g. GitLab).