Skip to content

install sphinx test dependencies in all CI testing jobs #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 19, 2024
Merged

install sphinx test dependencies in all CI testing jobs #1772

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f25485
CI: install sphinx test deps always
drammock Apr 17, 2024
da3b4a3
fix it right this time
drammock Apr 17, 2024
9888e98
pin sphinx<7.3 for site builds
drammock Apr 18, 2024
19769e6
Fix Sphinx version
trallard Apr 18, 2024
9c8066b
Pin Sphinx in pyproject.toml
trallard Apr 18, 2024
cfaee23
bump ablog; unpin sphinx
drammock Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,16 @@ jobs:
matrix:
os: [ubuntu-latest]
python-version: ["3.9", "3.10", "3.11", "3.12"]
sphinx-version: [""]
sphinx-version: ["rls"]
include:
# macos test
- os: macos-latest
python-version: "3.12"
sphinx-version: "rls"
# windows test
- os: windows-latest
python-version: "3.12"
sphinx-version: "rls"
# old Sphinx test
- os: ubuntu-latest
python-version: "3.9"
Expand Down
8 changes: 4 additions & 4 deletions tools/github_actions_install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
# ($2) is an extra dependency (currently just nox on one run)
set -eo pipefail
export PYTHONUTF8=1
if [[ "$SPHINX_VERSION" == "" ]]; then
SPHINX_INSTALL=""
if [[ "$SPHINX_VERSION" == "rls" ]]; then
SPHINX_INSTALL="sphinx[test]"
elif [[ "$SPHINX_VERSION" == "dev" ]]; then
SPHINX_INSTALL="sphinx[test]@https://codeload.github.com/sphinx-doc/sphinx/zip/refs/heads/master"
elif [[ "$SPHINX_VERSION" == "old" ]]; then
SPHINX_INSTALL="sphinx[test]==6.1.0"
else # not used currently but easy enough
SPHINX_INSTALL="sphinx[test]==$SPHINX_VERSION"
else # for the "build site" jobs
SPHINX_INSTALL="sphinx<7.3"
fi
set -x # print commands
python -m pip install --upgrade pip wheel setuptools
Expand Down
Loading