Skip to content

Clear alt_text in conf.py #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 17, 2023
Merged

Clear alt_text in conf.py #1471

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6df596a
comment out alt_text in conf.py
gabalafou Sep 21, 2023
88dc9f3
set alt_text to empty string
gabalafou Sep 21, 2023
748850b
Merge branch 'main' into remove-pst-logo-alt-text
gabalafou Sep 27, 2023
3b1d136
remove alt_text from conf.py
gabalafou Sep 27, 2023
8ab8b87
Merge branch 'main' into remove-pst-logo-alt-text
gabalafou Oct 3, 2023
f38f10e
Merge branch 'main' into remove-pst-logo-alt-text
gabalafou Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/conf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@
# "twitter_url": "https://twitter.com/PyData",
"logo": {
"text": "PyData Theme",
"alt_text": "", # PST logo is decorative so mute the alt text
Copy link
Collaborator Author

@gabalafou gabalafou Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My first attempt to fix the Axe test failure was to comment this line out, but the theme uses "Logo image" as the default alt text if the client does not specify any, which resulted in the home page link appearing as "Logo image PyData Theme" to assistive tech.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once #1472 is merged then we could simply comment out / remove this line though, right? i.e. #1472 would make this PR moot?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scratch that: not moot, but possible to simply delete the line.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's merge #1472 first, then just delete the line here

"image_dark": "_static/logo-dark.svg",
"alt_text": "PyData Theme",
},
"use_edit_page_button": True,
"show_toc_level": 1,
Expand Down