Update AlgebraicSolver
tolerances + default ESOH
solver method
#4982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the
AlgebraicSolver
would only declare success if the absolute tolerance of the residuals were below thetol
threshold. However, the scipy solvers would frequently terminate if other thresholds were hit, such asxtol
orgtol
, andAlgebraicSolver
may erroneously throw an error even after a successful solveThis PR:
xtol
andgtol
from1e-8
to1e-12
to reflect the fact that we desireall(abs(f(x)) < tol)
all(abs(f(x)) < tol)
is satisfiedElectrodeSOHHalfCell
to trust-region instead of a minimizerType of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commit
nox -s tests
nox -s doctests