Fix: config option name not printing as application #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x for unsupported logger error
|
DeanAyalon
changed the title
|
Apologies for the mess, Github published my PR before posting the Issue or editing the information within And sorry for the wait, I had this fix for a while but had other things on my mind 😅 |
|
Hi, looks ok, but it would be better if you cover this with 2 tests(with and without name option) can you add them? |
|
I'm sorry I don't think I understand what to check for and where |
pustovitDmytro
added a commit
that referenced
this pull request
Apr 5, 2024
* Fix: config option name not printing as application; Minor grammar fix for unsupported logger error (#128) * Chore: adds tests to application name configuration --------- Co-authored-by: Dean Ayalon <[email protected]>
pustovitDmytro
added a commit
that referenced
this pull request
Apr 5, 2024
…x for unsupported logger error (#130) * Fix: config option name not printing as application; Minor grammar fix for unsupported logger error (#128) * Chore: adds tests to application name configuration --------- Co-authored-by: Dean Ayalon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
My apologies, the PR was posted before I had the chance to edit all the information
Tests do not throw errors, except
npm run test:package- Which I am not sure about, is it my global Node version crashing it?Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
Changes:
nameinstead ofthis.namewhen passing logged data property 'application'logger does not support ${lev} level, also added alternative wording in commentFixes #129
closes #129
NPM Tests: