Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend comment to Ord noting that Number is not fully law abiding #277

Merged
merged 2 commits into from
Nov 9, 2021
Merged

Extend comment to Ord noting that Number is not fully law abiding #277

merged 2 commits into from
Nov 9, 2021

Conversation

JamieBallingall
Copy link
Contributor

@JamieBallingall JamieBallingall commented Nov 9, 2021 •
edited
Loading

Adds a note in the comment to the Ord typeclass indicating that Number does not have a fully law abiding instance of Ord. This is because NaN <= NaN evaluates to false.

This PR closes #276.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@thomashoneyman thomashoneyman merged commit ac720e4 into purescript:master Nov 9, 2021
@JamieBallingall JamieBallingall deleted the ordnote branch July 5, 2022 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyb garyb garyb approved these changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Number is not a fully law abiding instance of Ord
3 participants
@JamieBallingall @garyb @thomashoneyman