Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add toRep #238

Merged
merged 3 commits into from
Dec 26, 2020
Merged

Add toRep #238

merged 3 commits into from
Dec 26, 2020

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Dec 25, 2020 •
edited
Loading

Fixes #246

kl0tl
kl0tl reviewed Dec 25, 2020
View reviewed changes
src/Data/Generic/Rep.purs Outdated
@@ -34,3 +37,6 @@ newtype Argument a = Argument a
class Generic a rep | a -> rep where
to :: rep -> a
from :: a -> rep

toRep :: forall from to. Generic from to => Proxy from -> Proxy to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we reuse a and rep variables, like in the class declaration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

src/Data/Generic/Rep.purs Outdated
@@ -34,3 +37,6 @@ newtype Argument a = Argument a
class Generic a rep | a -> rep where
to :: rep -> a
from :: a -> rep

toRep :: forall from to. Generic from to => Proxy from -> Proxy to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I don’t know about you but I frequently confuse to and from, and I’m sure having to :: rep -> a but toRep :: Proxy a -> Proxy rep is going to be even more confusing to me 😬 May I suggest repOf instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

kl0tl
kl0tl approved these changes Dec 25, 2020
View reviewed changes
Copy link
Member

@kl0tl kl0tl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JordanMartinez JordanMartinez merged commit 894e8f9 into purescript:master Dec 26, 2020
@JordanMartinez JordanMartinez mentioned this pull request Dec 26, 2020
Closed
@hdgarrood hdgarrood mentioned this pull request Jan 13, 2021
Merged
4 tasks
turlando pushed a commit to purescm/purescript-prelude that referenced this pull request Sep 3, 2021
@JordanMartinez @turlando
Add toRep (purescript#238)
85fa966 
* Add toRep

* Update type variable names to match class names

* Rename toRep to repOf
@JordanMartinez JordanMartinez deleted the addToRep branch September 24, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kl0tl kl0tl kl0tl approved these changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[generics-rep] Add a toRep function
3 participants
@JordanMartinez @kl0tl @thomashoneyman