Skip to content

Add/finish Ord instance for Records #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Add/finish Ord instance for Records #180

merged 1 commit into from
Jul 17, 2018

Conversation

LiamGoodacre
Copy link
Member

Fixes #176

It's very annoying that we didn't make this instance, especially when it disrupts upgrading in some cases: removal-of-deriving-for-records-in-generics-rep#3.

@garyb
Copy link
Member

garyb commented Jul 16, 2018

I'm for it 👍

Anyone feel strongly against it for any reason? Speak now or forever hold your peas.

@hdgarrood
Copy link
Contributor

I’m slightly uneasy about the potential for people to use a type synonym for a particular record type and expect its Ord instance to use the order written in the type synonym declaration, as was discussed somewhere a while ago (I can’t be bothered to hunt for it right now). This is a fairly minor objection though, and instance is clearly useful so 👍

@natefaubion
Copy link

natefaubion commented Jul 17, 2018

@hdgarrood I don't think that's any different than people using Ord deriving and expecting the compiler to use the order of the fields in the data declaration. Edit: To clarify, for records.

@garyb garyb merged commit 7a691ce into purescript:master Jul 17, 2018
@LiamGoodacre LiamGoodacre deleted the feature/ord-record branch July 18, 2018 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants