Nested classes/pdoc 35 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subclasses have their superclass as part of their namespace and objects in the subclass's namespace must be registered first. Reverse the list of parsed objects so that the classes will be handled and registered in the correct order.
| expect(read_html(tmp, 'test', | ||
| 'outer/middle.html')).to include("Puppet Class: middle") | ||
| expect(read_html(tmp, 'test', | ||
| 'outer/middle/inner.html')).to include("Puppet Class: inner") |
There was a problem hiding this comment.
I think it would be worthwhile to check in the test that the classes have the expected namespaces. I believe the namespace for each class should reflect the class it's nested in.
There was a problem hiding this comment.
That description is also incorrect.
iankronquist
force-pushed
the
nested-classes/pdoc-35
branch
from
eb3e622 to
457ec86
Compare
|
@HAIL9000 added a test to address your comment and fixed test name. |
|
@HAIL9000 I think Shaigy wants to test this. Would you mind looking at this again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.