Only set tasks = true when parsing plans. #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binford2k
changed the title
The tests fail because the tested pathname is not the same pattern, so the regex fails. Do you have suggestions @scotje? Fixes puppetlabs#251
binford2k
commented
Dec 17, 2020
| if Puppet::Util::Package.versioncmp(Puppet.version, "5.0.0") < 0 && @file.to_s.match(/^plans\//) | ||
| log.warn "Skipping #{@file}: Puppet Plans require Puppet 5 or greater." | ||
| return | ||
| if @file.to_s.match(/^plans\//) |
There was a problem hiding this comment.
@scotje this regex fails during testing because it's in the full fixtures directory. If I remove the start-of-string anchor, tests pass, but that's probably not a good solution. Any other ideas?
There was a problem hiding this comment.
We should probably extract this test into a helper method and then we can stub that out in the tests
|
Hey @binford2k just wondering if this is still functionality you are still interested in working on? |
|
@pmcmaw I'll finish it up next week after kickoff |
|
Hello @binford2k, there's probably a little more required now to get the PR across the line. What would you like to do? |
da-ar
reviewed
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only set tasks = true when parsing plans. The tests fail because the tested pathname is not the same pattern, so the regex fails. Do you have suggestions @scotje?
Fixes #251