(PDOC-26) Rename Puppetx to PuppetX #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This is the new pull request which is the updated version of #24) |
Due to the changes in PUP-3900 which renamed Puppetx to PuppetX and puppetx to puppet_x, strings was failing since the namespace had not been updated in strings. In order to be compatible with this change, update strings by renaming the namespace to match. In order to ensure strings is still compatible with earlier versions of puppet that don't include the namespace change, declare our own PuppetX module. This way, if it is an older version and the namespace is called Puppetx, the necessary PuppetX namespace will be created.
HAIL9000
force-pushed
the
issue/master/PDOC-26_update_puppetx_module_name
branch
from
f579a17 to
e5691d2
Compare
hlindberg
added a commit
that referenced
this pull request
Feb 7, 2015
…tx_module_name (PDOC-26) Rename Puppetx to PuppetX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes in PUP-3900 which renamed Puppetx to PuppetX
and puppetx to puppet_x, strings was failing since the namespace
had not been updated in strings. In order to be compatible with this
change, update strings by renaming the namespace to match.
In order to ensure strings is still compatible with earlier versions
of puppet that don't include the namespace change, declare our own
PuppetX module. This way, if it is an older version and the namespace
is called Puppetx, the necessary PuppetX namespace will be created.