(maint) Use parameters method instead of json['parameters'] #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eputnam
approved these changes
Sep 23, 2019
When a task doesn't have parameters and a user generates markdown for the task, this line would error because it can't iterate on `nil`. This modifies it to use the `TaskStatement` method `parameters` which sets a default empty hash when a task doesn't have parameters. This additionally updates `Net::SSH::Verifier::Null` to be `Net::SSH::Verifier::Never` per [this update](net-ssh/net-ssh@29a8e97#diff-2174f2c10092abd65be32625cf19c0e7) to Net SSH
lucywyman
force-pushed
the
maint-set-default-parameters
branch
from
ff31f13 to
5fc6bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a task doesn't have parameters and a user generates markdown for
the task, this line would error because it can't iterate on
nil. Thismodifies it to use the
TaskStatementmethodparameterswhich sets adefault empty hash when a task doesn't have parameters.