Skip to content

(PDOC-255) markdown table of contents update #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

eputnam
Copy link
Contributor

@eputnam eputnam commented Jun 4, 2018

Markdown output does not currently distinguish between the group headings for the table of contents and group headings in the actual content. This change adds a 'Table of Contents' heading and changes group headings to bold text to make it much more clear that you're looking at the table of contents.

Markdown output does not currently distinguish between the group headings for the table of contents and group headings in the actual content. This change adds a 'Table of Contents' heading and changes group headings to bold text to make it much more clear that you're looking at the table of contents.
@eputnam eputnam added the feature label Jun 4, 2018
@eputnam eputnam requested review from jhelwig, melissa and jbondpdx June 4, 2018 03:28
@eputnam
Copy link
Contributor Author

eputnam commented Jun 4, 2018

Sample output with these changes:
screen shot 2018-06-03 at 8 22 31 pm

Copy link

@jhelwig jhelwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🥇

Copy link
Contributor

@kris-bosland kris-bosland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@kris-bosland
Copy link
Contributor

I don't see a button for merge - I assume it's a permission problem but I don't know where to look for the permissions.

@scotje scotje merged commit d122b19 into puppetlabs:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants