(PDOC-129) Include tags in overload objects when serialized as JSON #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should probably be merged after #119 to prevent a bigger rebasing headache. I'll have to rebase this once that's merged, though. |
whopper
force-pushed
the
PDOC-129/master/overload-empty-docstring
branch
2 times, most recently
from
6eb2e8b to
94c06e7
Compare
scotje
approved these changes
Nov 4, 2016
|
@scotje indeed, it's a bit dumb. Actually, we may be able to use the |
|
Yeah, it looks like |
whopper
force-pushed
the
PDOC-129/master/overload-empty-docstring
branch
from
94c06e7 to
ceb8156
Compare
|
@scotje updated to use |
|
Hooray! |
|
LGTM |
Previously, overload objects were not displaying their tags when they had no docstring text. This was due to an issue in the overload `to_hash` method, which prevented the tags from being serialized when the dispatch had no top-level text. This commit updates that logic so that the tags will always be included in the hash if they exist.
whopper
force-pushed
the
PDOC-129/master/overload-empty-docstring
branch
from
ceb8156 to
c56d9c6
Compare
|
@scotje rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, overload objects were not displaying their tags when
they had no docstring text. This was due to an issue in the overload
to_hashmethod, which prevented the tags from being serialized whenthe dispatch had no top-level text. This commit updates that logic
so that the tags will always be included in the hash if they exist.