(PDOC-126) Remove %Q ruby quotation syntax from parsed strings
#118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scotje
reviewed
Oct 28, 2016
| # @param [String] str The string to scrub. | ||
| # @return [String] A scrubbed string. | ||
| def self.scrub_string(str) | ||
| match = str.match(/^%[Qq]{(.*)}/m) |
There was a problem hiding this comment.
maybe add the end of string anchor to this regex
Previously, YARD would parse ruby strings which used %Q notation and return the syntax literally. This commit adds a new Util module with a `scrub_string` method to check for such a string and remove the errant %Q and %q's.
whopper
force-pushed
the
PDOC-126/master/ruby_quotes
branch
from
368465d to
c4705d9
Compare
scotje
approved these changes
Oct 28, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, YARD would parse ruby strings which used %Q notation
and return the syntax literally. This commit adds a new Util
module with a
scrub_stringmethod to check for such a stringand remove the errant %Q and %q's.