-
Notifications
You must be signed in to change notification settings - Fork 86
(PDOC-95) Properly group and display multiple provider defaultfor
s
#111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PDOC-95) Properly group and display multiple provider defaultfor
s
#111
Conversation
Here's a before and after for the systemd provider, which has the following defaults:
Before: The JSON looks like:
|
👍 |
Question though: is |
@peterhuene |
434060f
to
bf5ecd1
Compare
@peterhuene updated to use list of lists and verified the case of defaultfor osfamily: 'RedHat', osfamily: 'Gentoo' is displayed correctly (and that everything else still works) |
Prior to this commit, strings did not properly handle providers which had multiple related `defaultfor`s. In code, these are written as comma-separated constraints. This commit updates strings' puppet provider handler, as well as the template which generates HTML for `defaultfor` statements. Note that it was necessary to make a breaking change to the JSON schema to accomodate multiple AND'ed defaults. Previously, provider defaults were contained in a single key-value map. Now, they are contained in an array of key-value lists, which allows multiple constraints to be associated with each other.
bf5ecd1
to
a5a3d6b
Compare
Prior to this commit, strings did not properly handle providers
which had multiple related
defaultfor
s. In code, these are writtenas comma-separated constraints. This commit updates strings' puppet
provider handler, as well as the template which generates HTML for
defaultfor
statements.Note that it was necessary to make a breaking change to the JSON
schema to accomodate multiple AND'ed defaults. Previously, provider
defaults were contained in a single key-value map. Now, they are
contained in an array of key-value maps, which allows multiple
constraints to be associated with each other.