feat(puppetcore): Add puppetcore gem source switch capability #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
previously approved these changes
Mar 25, 2025
gavindidrichsen
force-pushed
the
OSPTE-198
branch
from
d84e7d7 to
b91af9d
Compare
gavindidrichsen
force-pushed
the
OSPTE-198
branch
from
1b6bb60 to
861e7a3
Compare
Puppetcore only works with ruby >= 3.x, so puppet must also be >= 8. This is inline with other changes being rolled out across the repositories. Signed-off-by: Gavin Didrichsen <[email protected]>
Add puppetcore switch to Gemfile. This ensures that when the PUPPET_FORGE_TOKEN is set, then the puppetcore gems are used. If this variable is not set, the bundle install will still work as normal with the public puppet and facter gems. NOTE, however, that the corresponding tests will only pass if the puppetcore gems are present on CI and used. Signed-off-by: Gavin Didrichsen <[email protected]>
One of the cat-github-actions re-usable workflows has been updated to switch on the puppetcore. For reference see <puppetlabs/cat-github-actions#129>. This means a minor admustment is required on any modules that also need to run against puppetcore. One, `ruby_version` must be passed in and be >= 3.1; and two, the `PUPPET_FORGE_TOKEN` must be a secret on the repository. Signed-off-by: Gavin Didrichsen <[email protected]>
gavindidrichsen
force-pushed
the
OSPTE-198
branch
from
f9f993a to
b637e93
Compare
gavindidrichsen
changed the title
jordanbreen28
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces puppetcore gem source integration to the provision module. When
PUPPET_FORGE_TOKENenvironment variable is set, the module will use authenticated puppetcore gem sources; otherwise, it will default to public gem sources. This implementation follows the "switch" design pattern to ensure all modules work correctly regardless of whether puppetcore is used or not.Changes
Gemfile: Implemented conditional logic to use puppetcore gem source whenPUPPET_FORGE_TOKENis setci.ymlworkflow: Updated to use Ruby 3.1+ which is required for puppetcore gems. This workflow "uses" the shared cat-github-actions workflow that was updated in this PR: Add PuppetCore gem source support to module_ci workflow cat-github-actions#129metadata.json: Updated Puppet version requirement to 8.0.0+ to align with puppetcorespec/integration/puppetcore_spec.rb: Added integration tests to verify correct gem sources are used