-
Notifications
You must be signed in to change notification settings - Fork 130
feat: add Ionoscloud provider #7377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hey @rmocanu-ionos, thanks a lot for your interest in adding a new package to our registry! For reference, I'll be using this checklist to confirm the provider is correctly showing up in the registry:
|
|
||
The Pulumi `Ionoscloud` provider is available as a package in most Pulumi languages: | ||
|
||
* JavaScript/TypeScript: [`@ovhcloud/pulumi-ovh`](https://www.npmjs.com/package/@ionos-cloud/sdk-pulumi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text of this link should probably be @ionos-cloud/sdk-pulumi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmocanu-ionos just checking in, do you want to continue with with adding the provider to the registry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, yes, we want to. Sorry, I was under the impression that you need to do something to run the workflow for this pr or something. Should I make a new tag with this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please release a new version of the provider with this fix and then I’ll take it from here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a new release (v0.2.2) with the change, should I regenerate the docs and add the changes to this pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No that's fine, I'll need to create a separate PR for verification anyways
@rmocanu-ionos please also remember to fill out the form I mentioned in the comment above: #7377 (comment) |
@rmocanu-ionos here's a preview version of how the IonosCloud provider will look like in the registry: http://registry--origin-pr-7539-dc0b4ddb.s3-website.us-west-2.amazonaws.com/registry/packages/ionoscloud/ One thing I've noticed is that you do not have a |
Hello, I have made a new release with the logo. Regarding the form I sent it to some colleagues and they are looking into it |
@rmocanu-ionos this worked, the logo is shown in the registry now: http://registry--origin-pr-7539-fded80f6.s3-website.us-west-2.amazonaws.com/registry/packages/ionoscloud/ From a technical perspective this looks good. Please let me know once you've submitted the contact details! |
hello, Pulumi team. This PR adds the Ionoscloud provider package to the pulumi registry. This package allows users to provision Ionoscloud resources that are also available in our terraform provider here.
v
(e.g.v0.1.0
). Thepart after the leading
v
must be valid semver 2.0.schemaFile
specified in
/community-packages/package-list.json
./docs/_index.md
and/docs/installation-configuration.md
filledout in your repo.
/docs/installation-configuration.md
links to all published SDKs./docs/index.md
shows an example of using your provider in each language.