Fixed a flat repo edge case with zero-byte artifacts #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstct
force-pushed
the
fix-empty-file-edgecase
branch
from
cb049de to
33efb7f
Compare
quba42
previously approved these changes
May 22, 2025
There was a problem hiding this comment.
I left a few possibilities for amending the release notes.
Ultimately I am fine with any of the variants, including the existing one, so I am approving this PR, and leaving the final choice of release notes + merge to @hstct.
hstct
force-pushed
the
fix-empty-file-edgecase
branch
from
33efb7f to
b8dae92
Compare
quba42
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1279