Skip to content

Add better flat repo handling for structure publish #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add better flat repo handling for structure publish #1257

wants to merge 2 commits into from

Conversation

hstct
Copy link
Contributor

@hstct hstct commented Apr 2, 2025 •
edited
Loading

closes #1258

@hstct hstct force-pushed the flat-repo-structure-2 branch from 2b6eec1 to ff14b16 Compare April 2, 2025 15:45
m-bucher
m-bucher approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@m-bucher m-bucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I am not the complete expert 😊

@hstct hstct force-pushed the flat-repo-structure-2 branch from ff14b16 to a147576 Compare April 3, 2025 14:28
@hstct hstct force-pushed the flat-repo-structure-2 branch from a147576 to db3ec73 Compare April 3, 2025 14:28
@m-bucher m-bucher force-pushed the flat-repo-structure-2 branch from 730b286 to 58789a2 Compare April 4, 2025 17:16
quba42
quba42 approved these changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@quba42 quba42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did another round of testing with several flat repos (including the dread nvidia cuda repo), everything worked as I expected.

Feel free to squish and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-bucher m-bucher m-bucher approved these changes

@quba42 quba42 quba42 approved these changes

Assignees
No one assigned
Labels
multi-commit no-changelog no-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publishing flat repositories should not report different distribution
3 participants
@hstct @m-bucher @quba42