Skip to content

Use same dependencies as docker container in alphabetic order #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 12, 2020
Merged

Use same dependencies as docker container in alphabetic order #114

merged 9 commits into from
May 12, 2020

Conversation

sharkwouter
Copy link
Member

There were a couple of dependencies missing and a couple which were not needed in both the readme and the dependency install script. Here is a list:

  • Cmake and Doxygen were not in the list at the top.
  • The list at the top was almost alphabetically ordered, but not quite.
  • The command for installing the dependencies on Ubuntu had build-essential and libsdl-dev in it, which are not required.

Now I do really wonder if Doxygen is used when building the toolchain. The toolchain script does check if it is there, but that was the case for SDL as well, which wasn't needed either.

@carstene1ns
Copy link
Member

  • doxygen is used by some libraries for generating documentation (e.g. opentri)
  • build_essential is a meta package that provides gcc, g++ and make.
    These are explicitly included already, but it should be included if the debian folks ever decide to rename packages or something.

@sharkwouter
Copy link
Member Author

Ah, that explains the doxygen mystery. I did find it is being used by 2 packages when I build the toolchain again.

Since we were already telling people explicitly to install gcc, g++ and make, we may as well leave out build-essential, in case more which we don't need is added to it in future versions.

@carstene1ns
Copy link
Member

I would like to merge this after adaption in/from #118.

@carstene1ns carstene1ns self-assigned this May 3, 2020
@sharkwouter
Copy link
Member Author

The following were added after making this merge request and will be removed if this is merged:

  • xz-utils
  • bzip2
  • gzip

I'm not sure if these are really necessary. Especially xz-utils seems odd. gzip and bzip2 are part installed by default on most systems, but setting tar instead may make more sense..

@sharkwouter
Copy link
Member Author

Okay, I see now, this was added in commit 5fc6ae5. Will add them back.

@carstene1ns
Copy link
Member

gmp, mpfr and mpc should be removed, they are not needed and will be built.
The compression formats should be listed explicitly, as we cannot guarantee archives get extracted after switching to them.

@sharkwouter
Copy link
Member Author

I've added them back in and included tar. I'm currently testing to see if the toolchain builds with the dependencies you mentioned removed in from the Dockerfile, will update when it's done building.

@sharkwouter
Copy link
Member Author

@carstene1ns you were right, no issues with those dependencies not installed.

@sharkwouter
Copy link
Member Author

I've now added pkg-config as well.

@carstene1ns
Copy link
Member

What about pacman libs?

@sharkwouter
Copy link
Member Author

Okay, I've added the pacman dependencies to the README and the debian/ubuntu prepare script.

@carstene1ns carstene1ns merged commit 541b460 into pspdev:master May 12, 2020
@sharkwouter sharkwouter deleted the feature/remove-sdl-dev-references branch June 10, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants