-
Notifications
You must be signed in to change notification settings - Fork 124
Use same dependencies as docker container in alphabetic order #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same dependencies as docker container in alphabetic order #114
Conversation
|
Ah, that explains the doxygen mystery. I did find it is being used by 2 packages when I build the toolchain again. Since we were already telling people explicitly to install gcc, g++ and make, we may as well leave out build-essential, in case more which we don't need is added to it in future versions. |
I would like to merge this after adaption in/from #118. |
The following were added after making this merge request and will be removed if this is merged:
I'm not sure if these are really necessary. Especially xz-utils seems odd. gzip and bzip2 are part installed by default on most systems, but setting tar instead may make more sense.. |
Okay, I see now, this was added in commit 5fc6ae5. Will add them back. |
gmp, mpfr and mpc should be removed, they are not needed and will be built. |
I've added them back in and included tar. I'm currently testing to see if the toolchain builds with the dependencies you mentioned removed in from the Dockerfile, will update when it's done building. |
@carstene1ns you were right, no issues with those dependencies not installed. |
I've now added pkg-config as well. |
What about pacman libs? |
Okay, I've added the pacman dependencies to the README and the debian/ubuntu prepare script. |
There were a couple of dependencies missing and a couple which were not needed in both the readme and the dependency install script. Here is a list:
Now I do really wonder if Doxygen is used when building the toolchain. The toolchain script does check if it is there, but that was the case for SDL as well, which wasn't needed either.