Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid setuptools config in setup.cfg (will fail on setuptools>78.0.0) #6920

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abravalheri
Copy link

@abravalheri abravalheri commented Mar 24, 2025

In version 78 of setuptools, the invalid configuration in setup.cfg will start to fail (there has been a deprecation warning since 3 Mar 2021).

I also noticed that most of the information provided to setup.cfg is repeated in setup.py, so I removed the duplicated copies in setup.cfg, because the project seems to be primarily using setup.py.

Alternatively, I can also try to migrate the static configs to pyproject.toml if desired (please let me know).

@abravalheri abravalheri changed the title Fix invalid setuptools config in setup.cfg Fix invalid setuptools config in setup.cfg (will fail on `setuptools>78.0.0) Mar 24, 2025
@abravalheri abravalheri marked this pull request as ready for review March 24, 2025 10:36
@abravalheri abravalheri changed the title Fix invalid setuptools config in setup.cfg (will fail on `setuptools>78.0.0) Fix invalid setuptools config in setup.cfg (will fail on setuptools>78.0.0) Mar 24, 2025
@fogti
Copy link

fogti commented Mar 27, 2025

It feels like removing stuff from setup.cfg instead of from setup.py (which could just parse the setup.cfg and get that information from there) is a mistake, simply because it removes information from simple declarative config and makes it only available via imperative config.

@abravalheri
Copy link
Author

abravalheri commented Mar 27, 2025

Alternatively, I can also try to migrate the static configs to pyproject.toml if desired (please let me know).

Fair enough, as I mentioned before, if the maintainers are interested:

Alternatively, I can also try to migrate the static configs to pyproject.toml if desired (please let me know).

In my opinion that would be best case scenario, but I don't know if there is a preference for centralising all the configs in setup.py (as it seems to be right now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants