Skip to content

Fix string normalization sometimes producing invalid fstrings #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2018
Merged

Fix string normalization sometimes producing invalid fstrings #327

merged 1 commit into from
Jun 9, 2018
+28 −1

Conversation

zsol
Copy link
Collaborator

@zsol zsol commented Jun 9, 2018

Fixes #322

I'm not 100% sure this covers all possible cases (especially around nesting), but I couldn't come up with counter examples

@coveralls
Copy link

coveralls commented Jun 9, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 536

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 96.215%
Totals Coverage Status
Change from base Build 534: 0.007%
Covered Lines: 2542
Relevant Lines: 2642
💛 - Coveralls

@ambv ambv merged commit 5d0a469 into master Jun 9, 2018
@ambv
Copy link
Collaborator

ambv commented Jun 9, 2018

Very quick turnaround. Thanks! ✨ 🍰 ✨

@ambv ambv deleted the fstring-backslash branch June 9, 2018 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zsol @coveralls @ambv