Crash under PyPy 7.0.0

[dholth]

black v19.3v0, running on PyPy

Python 3.6.1 (dab365a46514, Feb 05 2019, 18:05:11)
[PyPy 7.0.0-alpha0 with GCC 4.2.1 Compatible Apple LLVM 10.0.0 (clang-1000.11.45.5)]

error: cannot format x.py: 'PosixPath' does not support the buffer interface

The file appears to have been reformatted anyway.

PyPy 7.1 has the same issue.

[glyph]

Has this been filed against PyPy as well? This seems like divergent behavior which could be fixed there.

[dholth]

Good idea, I reported it there and they were able to reproduce the issue.

[hugovk]

For reference: https://bitbucket.org/pypy/pypy/issues/3015/black-crashes-on-pypy-7-with-posixpath

[JelleZijlstra]

So the problematic call looks like os.replace('x.py', pathlib.PosixPath('y.py')). To unblock users of Black, I'd accept a PR that makes our call to os.replace call str() on its arguments first.

[glyph]

Is this still a crasher?

[lietu]

It just crashed for me, so I guess it is. On PyPy 7.1.1 (on Ubuntu 16.04, pyenv install pypy3.6-7.1.1)

[hugovk]

I had a go testing Black with pypy3 on Travis CI:

• hugovk@d9a1e31

And there's an error installing one of Black's dependencies:

• Building wheel for typed-ast (setup.py) ... error

https://travis-ci.org/hugovk/black/jobs/567758215#L251

Unfortunately Typed AST doesn't support PyPy3. From Guido:

Yeah, it was never meant to run against PyPy. Once PyPy catches up with
Python 3.8 and we stop caring about 2.7 it should be possible to run mypy
under PyPy -- when run under Python 3.8 or later it uses the stdlib ast
module (which has grown APIs to request type comments and to support
earlier grammar versions (to some extent).

• Fails to build on pypy 7.0 (stdlib 3.5) as pgenheaders.h doesn't exist in pypy python/typed_ast#97 (comment)

[paugier]

These kinds of problems (error: cannot format x.py: 'PosixPath' does not support the buffer interface) have been fixed with PyPy3.6 7.2.0 (the first stable release of pypy3.6).

Now, the blocker for PyPy is the new typed-ast dependency (see #727 (comment)).

[JelleZijlstra]

Sounds like the original issue has been fixed in PyPy. #727 can track PyPy support in general.