Adjust combined infill flow to correct underextrusion #14614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined infill currently sets extrusion flow as if implicit extrusion cross-section scales proportionally with layer height. That would be true with a rectangular or cross-sectional extrusion model, but with a rounded rectangle model, the proportion of the extrusion taken by the two semicircles increases and the center rectangle narrows. This profile change with increased height/thickness causes underextrusion when width and spacing are both kept constant. Delivered density falls below the requested value and, in the worst case, the underextrusion can trigger "extrusion width too small?" errors as the rounded rectangle inverts past a circle. This change: 1) rescales rounded rectangle width to preserve requested fill density when fill surface thickness != layer height. 2) relaxes the requirement for aligned spacing in the event requested density is 100% (treating the fill as solid for Flow calculation, though preserving it as InternalInfill).
|
Ah, I see emacs spaces-vs-tabs has struck again. Sorry about that, I'll be happy to amend if desired. |
|
Rsubmitted as #14620 without the whitespace mangling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined infill currently sets extrusion flow as if implicit extrusion cross-section scales proportionally with layer height. That would be true with a rectangular or cross-sectional extrusion model, but with a rounded rectangle model, the proportion of the extrusion taken by the two semicircles increases and the center rectangle narrows.
This profile change with increased height/thickness causes underextrusion when width and spacing are both kept constant. Delivered density falls below the requested value and, in the worst case, the underextrusion can trigger "extrusion width too small?" errors as the rounded rectangle inverts past a circle.
This change:
rescales rounded rectangle width to preserve requested fill density when fill surface thickness != layer height.
relaxes the requirement for aligned spacing in the event requested density is 100% (treating the fill as solid for Flow calculation, though preserving it as InternalInfill).