[BUGFIX] Avoid invalid Wipetower G-Code (G1 F-2147483648) #14433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup instructions for some open source MMUs recommend setting all ramming and cooling parameters to 0 when using a filament cutter. This in turn leads to division by zero errors in the wipe tower g-code, and the outcome depends on the operating system and compiler being used. At least on builds for Windows with VC2019 the bug leads to invalid code for the cooling moves that looks like this: ``` ;WIDTH:0.5 G1 X98.896 Y232.718 G1 F3000 G1 F-2147483648 G1 F3000 G1 F-2147483648 G1 F3000 G1 F-2147483648 G1 F3000 G1 F-2147483648 G1 F2000 G1 X98.846 Y232.718 F2400 ``` The behavior seems to originate from the compiller spec recommending turning a NaN float value (from the division by zero) into an INT_MIN when casting from float to int. This diff avoids emitting the whole cooling move when either speed or distance are 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup instructions for some open source MMUs recommend setting all ramming and cooling parameters to 0 when using a filament cutter. This in turn leads to division by zero errors in the wipe tower g-code, and the outcome depends on the operating system and compiler being used.
At least on builds for Windows with VC2019 the bug leads to invalid code for the cooling moves that looks like this:
The behavior seems to originate from the compiller spec recommending turning a NaN float value (from the division by zero) into an INT_MIN when casting from float to int.
This diff avoids emitting the whole cooling move when either speed or distance are 0.