Skip to content

Support _created time series suppression #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Support _created time series suppression #793

wants to merge 1 commit into from

Conversation

dhoard
Copy link
Collaborator

@dhoard dhoard commented Jun 6, 2022 •
edited
Loading

Refactored @mindw 's code to try to increase performance/maintain minimal performance impact.

#774

@dhoard dhoard mentioned this pull request Jun 6, 2022
Merged
2 tasks
@dhoard
Copy link
Collaborator Author

dhoard commented Jun 6, 2022

The PR code is correct, but the build failed...

Tests run: 15, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.056 sec <<< FAILURE!
testTimeWithExemplar(io.prometheus.client.HistogramTest)  Time elapsed: 0.021 sec  <<< FAILURE!
java.lang.AssertionError: expected:<0.015> but was:<0.016387632>

Not sure how to resolve... increases the expected time?... Works on my machine.

@fstab
Copy link
Member

fstab commented Jun 11, 2022

Review comments in #791.

@fstab
Copy link
Member

fstab commented Jun 15, 2022

#791 merged.

@fstab fstab closed this Jun 15, 2022
@dhoard dhoard deleted the suppress_created branch October 4, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhoard @fstab