Skip to content

Fix appending custom values to specs #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025
Merged

Fix appending custom values to specs #187

merged 1 commit into from
Jun 25, 2025

Conversation

NelsonVides
Copy link
Member

@NelsonVides NelsonVides commented Jun 25, 2025

Fixes a bug introduced at #181 when we introduced maps as specs, as histograms and summaries would append values as if they were still lists.

@NelsonVides NelsonVides self-assigned this Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/metrics/prometheus_histogram.erl 95.72% <100.00%> (ø)
src/metrics/prometheus_quantile_summary.erl 92.36% <100.00%> (+0.05%) ⬆️
test/eunit/metric/prometheus_histogram_tests.erl 98.28% <100.00%> (+0.05%) ⬆️
...eunit/metric/prometheus_quantile_summary_tests.erl 98.13% <100.00%> (+0.08%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NelsonVides NelsonVides merged commit 02df2e1 into master Jun 25, 2025
7 checks passed
@NelsonVides NelsonVides deleted the specs_as_maps branch June 25, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants