-
Notifications
You must be signed in to change notification settings - Fork 121
Upgrade plugins and fix new linter errors #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
80a1b36
to
1208d67
Compare
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Regarding [
{{A, N}, lists:sort(proplists:delete(versions, Props))}
|| A <- Allocators,
Allocs <- [erlang:system_info({allocator, A})],
Allocs =/= false,
{_, N, Props} <- Allocs
]. I haven't tested this, but [
{{A, N}, lists:sort(proplists:delete(versions, Props))}
|| A <- Allocators,
{_, N, Props} <- [erlang:system_info({allocator, A})]
]. should work, even if it's less readable (because you lose the filter, which is implicit). |
Avoiding rules is also a possibility, but I tend not to do it at the project level, but start at the function level. Instead of |
2833cb7
to
4c54547
Compare
Ok, went around what the lists are supposed to be and found a different fix, it should be good to go now. Review plis? 🙏🏽😄 |
@@ -255,8 +255,9 @@ allocators() -> | |||
[ | |||
{{A, N}, lists:sort(proplists:delete(versions, Props))} | |||
|| A <- Allocators, | |||
Allocs <- [erlang:system_info({allocator, A})], | |||
Allocs =/= false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hurray. That's what the rule is there for, to make us think about alternatives. If there's none we avoid it, but in this case there was a good solution for us 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I just changed the code to make it more explicit, I find this list comprehension quite a terse hack, and also, what if SMP is disabled for ERTS (why tf would do that but you never know), then the number of allocators would be actually just one and this would return empty. Better make it just explicit, wdyt? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, you changed it. Lemme give it a quick look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like explicit, yeah; if it works, it works. I just though you were going for minimal change, so the previous one (even if implicit) also worked for me.
4c54547
to
0a4c813
Compare
@paulo-ferraz-oliveira tagging you as I know you were working on the last release of Elvis :)