Skip to content

Upgrade OTP versions, supporting now only 26/27/28 and adapting to enhancements #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025

Conversation

NelsonVides
Copy link
Member

@NelsonVides NelsonVides commented May 25, 2025

Takes advantage of dynamic() typing as well as of ets:lookup_element/4.

Tagging everyone as it might be a more "controversial" change.

Copy link

codecov bot commented May 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...llectors/vm/prometheus_vm_statistics_collector.erl 92.59% <ø> (ø)
src/metrics/prometheus_gauge.erl 96.55% <ø> (ø)
src/metrics/prometheus_histogram.erl 95.72% <100.00%> (ø)
src/metrics/prometheus_quantile_summary.erl 92.30% <ø> (ø)
src/metrics/prometheus_summary.erl 96.15% <ø> (ø)
src/prometheus_collector.erl 97.14% <ø> (ø)
src/prometheus_metric.erl 97.29% <ø> (ø)
src/prometheus_metric_spec.erl 100.00% <ø> (ø)
src/prometheus_misc.erl 86.66% <ø> (ø)
src/prometheus_registry.erl 96.87% <ø> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mkuratczyk
mkuratczyk previously approved these changes May 25, 2025
mikpe
mikpe previously approved these changes May 25, 2025
Copy link

@paulo-ferraz-oliveira paulo-ferraz-oliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments, but overall the change is acceptable, for me.

@NelsonVides NelsonVides changed the title Upgrade OTP versions, supporting now 26/27/28 Upgrade OTP versions, supporting now only 26/27/28 and adapting to enhancements May 26, 2025
@NelsonVides
Copy link
Member Author

Anybody wants to reapprove? Previous approvals were restarted after the last pushed changes :)

@mkuratczyk mkuratczyk self-requested a review May 27, 2025 14:02
@NelsonVides NelsonVides merged commit b89f97b into master May 27, 2025
7 checks passed
@NelsonVides NelsonVides deleted the otp28 branch May 27, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants