Improvements #183
Merged
Improvements #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimise convert_du time helper
NelsonVides
requested review from
paulo-ferraz-oliveira,
mkuratczyk and
onno-vos-dev
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Two things: when fetching for the buckets, lookup (and therefore only copy) the bucket config instead of the entire record). Second, keep buckets as a big tuple instead of a big list, which is smaller and therefore cheaper to copy, and also can apply binary search during the bucket lookup instead of linear search over a list.
mkuratczyk
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things for histograms: when fetching for the buckets, lookup (and therefore only copy) the bucket config instead of the entire record). Second, keep buckets as a big tuple instead of a big list, which is smaller and therefore cheaper to copy, and also can apply binary search during the bucket lookup instead of linear search over a list.
Also for gauges, improve their performance and fix a bug about setting a gauge to undefined for integer or floats.
Extracting from #177