Skip to content

Allow passing labels as maps, not just proplists #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

Allow passing labels as maps, not just proplists #179

merged 1 commit into from
May 20, 2025

Conversation

mkuratczyk
Copy link
Contributor

@mkuratczyk mkuratczyk commented May 20, 2025 •
edited
Loading 

#{label1 => value1, labels2 => value2}

becomes equivalent of

[{label1, value1}, {label2, value2}]

@mkuratczyk
Allow passing labels as maps, not just proplists
21244fc 
```
\#{label1 => value1, labels2 => value2}
```

becomes equivalent of
```
[{label1, value1}, {label2, value2}]
```
@codecov Codecov
Copy link

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/model/prometheus_model_helpers.erl 94.31% <100.00%> (+0.06%) ⬆️
test/eunit/prometheus_model_helpers_tests.erl 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@onno-vos-dev
Copy link
Member

Nice one!

@mkuratczyk mkuratczyk merged commit f82b084 into master May 20, 2025
4 checks passed
@mkuratczyk mkuratczyk deleted the allow-maps-of-labels branch May 20, 2025 16:15
@NelsonVides NelsonVides mentioned this pull request May 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onno-vos-dev onno-vos-dev onno-vos-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkuratczyk @onno-vos-dev