Global and prerendered labels #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binarin
force-pushed
the
global_and_prerendered_labels
branch
2 times, most recently
from
9f78b1c to
cebfe99
Compare
Without this change, a collector that pre-renders labels (like RabbitMQ) will return `<<>>` in case there are no labels at all. That will create an an improper list when an empty binary is appended to a list of global labels. Rather than dealing with improper list later, let's just avoid them.
binarin
force-pushed
the
global_and_prerendered_labels
branch
from
cebfe99 to
8fa48f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked #147 with tests