[prometheus] make path.rootfs conditional #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not always possible to mount / from host, see issue prometheus-community#467 Signed-off-by: William Johansson <[email protected]>
radhus
requested review from
gianrubio,
monotek,
naseemkullah,
Xtigyro and
zanhsieh
as code owners
radhus
force-pushed
the
node-exporter-rootfs-condition
branch
from
45e7a3c to
c1dbc3a
Compare
radhus
changed the title
monotek
requested changes
Mar 7, 2021
charts/prometheus/Chart.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v2 | |||
| name: prometheus | |||
| version: 13.4.0 | |||
| version: 13.4.1 | |||
There was a problem hiding this comment.
New feature should raise minor version.
There was a problem hiding this comment.
Fixed, bumped to 13.5.0
Signed-off-by: William Johansson <[email protected]>
Signed-off-by: William Johansson <[email protected]>
|
@monotek bumped it, I'd usually like to rebase the PR but the template says
Let me know if I shall proceed and do that or if it can be merged anyway. |
monotek
previously approved these changes
Mar 8, 2021
zanhsieh
approved these changes
Mar 9, 2021
|
Anything else needed to get this merged? 🙂 |
monotek
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Makes it configurable if node-exporter daemonset should mount
/from host or not. Default totrueto keep existing default behavior.As seen in issue #467, it is not always possible to mount / from host in all environments.
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[prometheus-couchdb-exporter])