-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fixed log level mismatch #6271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed log level mismatch #6271
Conversation
WalkthroughThe changes adjust logging behaviors in two areas: the debug callback in the DSL package now logs at the debug level instead of info, and error handling in the output package uses structured error logging instead of printing errors directly to standard output. Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
pkg/operators/common/dsl/dsl.go (1)
117-117
: Lower DSL print callback to Debug level
Switching fromInfo
toDebug
here correctly reduces verbosity for DSL debug output. Consider using%v
instead of%s
to log the slice of arguments directly and avoid the extrafmt.Sprint
call:- gologger.Debug().Msgf("print_debug value: %s", fmt.Sprint(args)) + gologger.Debug().Msgf("print_debug value: %v", args)pkg/output/output.go (1)
563-563
: Use structured error logging for debug file open failures
Replacingfmt.Print
withgologger.Error().Msgf
ensures consistency with the application's logging framework. For better diagnostics, include the filename being opened in the log message:- gologger.Error().Msgf("Could not open debug output file: %s", err) + gologger.Error().Msgf("Could not open debug output file %q: %v", filename, err)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
pkg/operators/common/dsl/dsl.go
(1 hunks)pkg/output/output.go
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Lint
Proposed changes
Checklist
Summary by CodeRabbit