-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix ingress template in helm chart #6206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Thanks for your contribution @23kbps ! :) As a token of appreciation for your valuable contribution, you can grab some cool PD Stickers from here http://nux.gg/stickers. We also have a Discord server, which you’re more than welcome to join. It's a great place to connect with fellow contributors and stay updated with the latest developments! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the ingress configuration in the Helm chart for Interactsh by correcting the service name and port values used in the ingress object.
- Updated the service port reference from .Values.service.port to .Values.interactsh.service.port.
- Introduced a service name variable from .Values.interactsh.service.name and updated ingress backend accordingly.
Comments suppressed due to low confidence (1)
helm/templates/interactsh-ingress.yaml:2
- The variable $fullName is defined but no longer used in the updated ingress configuration. Consider removing it to clean up the template.
{{- $fullName := include "nuclei.fullname" . -}}
Proposed changes
There is wrong service name and service port in ingress object of Helm template, which is broken if enabled ingress
Checklist