[BUG] Recursive call and logical errors in Dynamic. UnmarshalJSON implementation #6267
Description
Is there an existing issue for this?
- I have searched the existing issues.
Current Behavior
I found that the implementation of the UnmarshalJSON method for the Dynamic struct in pkg/authprovider/authx/dynamic. go contains a recursive call issue.
func (d *Dynamic) UnmarshalJSON(data []byte) error {
if err := json.Unmarshal(data, &d); err != nil {
return err
}
var s Secret
if err := json.Unmarshal(data, &s); err != nil {
return err
}
d.Secret = &s
return nil
}Problems:
Using json. Unmarshal(data, &d) will trigger an infinite recursion because it will call UnmarshalJSON on d repeatedly, leading to stack overflow.
The correct way to avoid recursion is to use a type alias that does not implement UnmarshalJSON.
Double unmarshalling of the same data is redundant and may cause confusion or data inconsistency.
Expected Behavior
Suggested Fix: You can avoid recursion by introducing a type alias, for example:
func (d *Dynamic) UnmarshalJSON(data []byte) error {
type DynamicAlias Dynamic
aux := &struct {
*DynamicAlias
}{
DynamicAlias: (*DynamicAlias)(d),
}
if err := json.Unmarshal(data, aux); err != nil {
return err
}
var s Secret
if err := json.Unmarshal(data, &s); err != nil {
return err
}
d.Secret = &s
return nil
}Steps To Reproduce
N/A
Relevant log output
N/AEnvironment
N/AAnything else?
No response