Skip to content

Create mitel-micollab-ucs-version-detect.yaml #12368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 24, 2025

Conversation

aushack
Copy link
Contributor

@aushack aushack commented Jun 16, 2025

Detect version number from JSON file

@princechaddha
Copy link
Member

Automated PR Review (Experimental)


Thank you for your contribution! You can join our Discord server. It's a great place to connect with fellow contributors and stay updated with the latest developments. Thank you once again.

Required Fixes

  • Fix template ID to match the filename (mitel-micollab-ucs-version-detect.yaml).
  • Update tags to be in lowercase and separated by commas without spaces (e.g., mitel,micollab,ucs,version,detect should be just mitel,micollab,ucs,version).
  • Remove commented-out # verified: true or uncomment it and provide verification if applicable.

Other Suggestions

  • Consider enhancing the matchers with additional criteria, such as checking for specific content in the response body. This could help confirm that the response corresponds to a valid version disclosure.
  • You might want to include more details in the description section about the implications of the version disclosure, if relevant.
  • Ensure that the extractors section contains a fallback mechanism or a separate matcher that can help in verifying the version in case it does not appear as expected.

Note: I am an AI Template bot which is still experimental, and the team will review the PR shortly.

@darses
Copy link
Contributor

darses commented Jun 16, 2025

Would it be possible to add the version extract to the existing MiCollab Panel detection? Or is the UCS different from the End User panel that is detected in that template? If this is the same, maybe a secondary HTTP request with version extractor would be better suites in that template.

Additionally, consider adding a word matcher on {"version": to avoid the weak matcher error.

@aushack
Copy link
Contributor Author

aushack commented Jun 16, 2025 via email

@darses
Copy link
Contributor

darses commented Jun 17, 2025

@aushack My point was not directed at the extraction. I think the JSON extractor is fine there. My recommendation was to add version as an additional matcher, so that you are not only relying on the status 200. The extractor does not work as a matcher, so the template would 'match' even if there is no JSON version extraction possible.

Check JSON version exists in response
@darses
Copy link
Contributor

darses commented Jun 17, 2025

Looks good, and also fixes the weak-matcher error!

@DhiyaneshGeek DhiyaneshGeek self-assigned this Jun 19, 2025
@DhiyaneshGeek DhiyaneshGeek added the Done Ready to merge label Jun 19, 2025
@ritikchaddha ritikchaddha merged commit e52e0b6 into projectdiscovery:main Jun 24, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants