-
Notifications
You must be signed in to change notification settings - Fork 179
fix(ci): remove harpoon from workflow #1414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Oliver Bähler <[email protected]>
✅ Deploy Preview for capsule-documentation canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1414 +/- ##
=====================================
Coverage 4.15% 4.15%
=====================================
Files 144 144
Lines 7108 7108
=====================================
Hits 295 295
Misses 6801 6801
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Just making aware of this @alegrey91, hope he can promptly fix Harpoon to keep it on the CI |
@alegrey91, I think I got the the bottom of it - LMKWYT: func decodeInstruction(instHex []byte) ([]uint64, error) {
var offsets []uint64
s := bytes.NewBufferString("")
for i := 0; i < len(instHex); {
inst, err := x86asm.Decode(instHex[i:], 64)
fmt.Printf("%04X\t%s\n", i, inst.String())
if err != nil {
fmt.Printf("Error on %d iteration: %v\n", i, err)
}
s.WriteString(fmt.Sprintf("%04X\t%s", i, inst.String()))
s.WriteString("\n")
fmt.Println(inst.Mode)
if err != nil {
return nil, err
}
if inst.Op == x86asm.RET {
offsets = append(offsets, uint64(i))
}
i += inst.Len
}
return offsets, nil
} In this function we are attempting to Decoding in 64-bit mode, but some of the instructions are incompatible with that mode. For example below I am getting AAS which is 32-bit mode instruction - documentation. From there the offset is broken.
|
@Svarrogh1337 good catch! |
@alegrey91 lets catchup in slack |
E2E is no longer working reliable. We are going through with this change. |
Signed-off-by: Oliver Bähler <[email protected]>
Sure, I'm sorry we are not being able to fix the problem. Locally I didn't have these problems. Maybe this is due to the limited resources on the runner. |
If we bump the timeout reasonably and combine it with #1428, we should be good, but I will try it over next few days. Running e2e locally works fine for me, so it must be related to the runner. |
No description provided.