fix(tenantresources): nil pointer for additionalmetadata #1413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation canceled.
|
Svarrogh1337
changed the title
Svarrogh1337
force-pushed
the
fix-1387
branch
2 times, most recently
from
24755d2 to
185c1bb
Compare
Svarrogh1337
changed the title
prometherion
requested changes
Apr 7, 2025
Svarrogh1337
changed the title
Signed-off-by: Hristo Hristov <[email protected]>
Svarrogh1337
changed the title
oliverbaehler
approved these changes
Apr 8, 2025
|
@prometherion, did the changes satisfy your review? |
prometherion
approved these changes
Apr 11, 2025
|
@prometherion after the CI fix there are still problems with the CI unrelated to this PR - https://github.com/projectcapsule/capsule/actions/runs/14358268752 |
|
@Svarrogh1337 sure, OCI dependencies on github are so ****. I think we need to perform an helm login with the ci credentials and increase the timeiut for the helm operation to fix this |
Signed-off-by: Hristo Hristov <[email protected]>
|
@prometherion @oliverbaehler here we go. e2e was successful after merging my previous changes from main. |
|
Amazing job, Hristo, love witnessing your efforts in getting Capsule fixed: LGTM! |
prometherion
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1387