-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minimal cve fixes x/net and k8s.io/kubernetes for 3.28 #9991
base: release-v3.28
Are you sure you want to change the base?
Conversation
/sem-approve |
go 1.23.0 | ||
|
||
toolchain go1.23.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error: go [list -e -json -compiled=true -test=false -export=false -deps=true -find=false -tags ignore_autogenerated -- ./lib/apis/...]: exit status 1: go: ../go.mod requires go >= 1.23.0 (running go 1.22.12; GOTOOLCHAIN=local)
v3.28 branch is currently built by golang 1.22 (included in calico/go-build v0.91). x/crypto v0.35+ requires golang 1.23 to build. We need to update this branch to golang 1.23 before incorporating the CVE fixes.
@@ -96,7 +98,7 @@ require ( | |||
k8s.io/klog/v2 v2.120.1 | |||
k8s.io/kube-aggregator v0.28.15 | |||
k8s.io/kube-openapi v0.0.0-20230717233707-2695361300d9 | |||
k8s.io/kubernetes v1.28.15 | |||
k8s.io/kubernetes v1.29.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be best to keep this dependency in the Kubernetes v1.28 release to avoid any potential compatibility issues with older v0.28.15 k8s libraries.
Description
Currently 3 cves in calico 3.28.3 according to trivy