feat: add default support for MTU auto-detection in Debian 12 enX interfaces #10148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
|
|
|
@joseluisgonzalezca thanks for the PR! This LGTM, but you'll need to sign the CLA to make the bot happy. |
|
Sorry about that. Though I have signed it. Now it should be done. |
tomastigera
reviewed
Apr 4, 2025
| @@ -466,7 +466,7 @@ type Config struct { | |||
| GoMaxProcs int `config:"int(-1);-1"` | |||
|
|
|||
| // Configures MTU auto-detection. | |||
| MTUIfacePattern *regexp.Regexp `config:"regexp;^((en|wl|ww|sl|ib)[Pcopsvx].*|(eth|wlan|wwan).*)"` | |||
| MTUIfacePattern *regexp.Regexp `config:"regexp;^((en|wl|ww|sl|ib)[PcopsvxX].*|(eth|wlan|wwan).*)"` | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With Debian 12 release, interfaces were renamed to enX. Current regular expression is not able to match those interfaces unless it's explicitly modified in the configuration parameters. This warning is shown in Calico in that case:
With this PR, we are able to provide native support for this kind of interfaces without any changes in configuration parameters.
Related issues/PRs
No related issues
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.