Release tool updates and refactoring #10139
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
danudey
commented
Apr 3, 2025
danudey
commented
- Make registry authentication automatic
- Logging cleanups
- Clean up image validation logging for readability
- Updates to docker config file parsing/loading
1. Split file logging off into a hook so we can have nicely formatted and readable logging output on the console 2. Set the file logging to debug all the time so that we can check debug logs afterwards even if we didn't enable debugging manually 3. Clean up some of the formatting to make things more legible
1. Log each failed validation separately 2. Modify the final error message to be a count of failed images rather than all output from every failure
1. Use `sync` module to only read/parse the config once, rather than for every image 2. Load registry authentication information when we load the config file, rather than on demand 3. For registries with configured credential helpers, load the config from the helpers 4. For registries which are configured but which lack credential helpers, fetch information from the configured credential store TODO: Refactor authentication information to a separate function, so that we can fetch secrets from credential helpers or secret stores even for registries that we don't have a stored (blank) config for.
danudey
added
docs-not-required
The GetAuth method can fetch authentication credentials if we have them defined, or attempt to fetch them from the credential helper or credential store if we don't. If a credential helper is configured for a domain but that domain has no entry in the auths map, we still query the credential helper anyway so that we don't get tripped up if the auths mapping is missing entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.