[release tool] auth and image validation fixups [master] #10032
+47
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danudey
added
docs-not-required
radTuti
requested changes
Mar 25, 2025
| } else if !result.exists { | ||
| missingImages = append(missingImages, r.imageComponents[result.name]) | ||
| } | ||
| } | ||
| if len(missingImages) > 0 { | ||
| resultsErr = fmt.Errorf("error validating %s images", len(missingImages)) |
There was a problem hiding this comment.
resultsErr should state all the missing images as well, simply having a length is not useful error information
| @@ -120,6 +120,8 @@ require ( | |||
| sigs.k8s.io/yaml v1.4.0 | |||
| ) | |||
|
|
|||
| require github.com/avast/retry-go/v4 v4.6.1 | |||
There was a problem hiding this comment.
this require should not be separated. put it in the appropirate existing require section.
also, I think it is overkill to add a rety library that is used once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor fixups to docker authentication and image existence validation