Use new set.Adaptive type in named port index #10027
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvin-tigera
added
release-note-required
fasaxc
force-pushed
the
adaptive-set
branch
2 times, most recently
from
0a336da to
54f7f1a
Compare
fasaxc
changed the title
fasaxc
changed the title
fasaxc
added
docs-not-required
Stores its contents differently depending on the number of items.
- 0 items -> size=0 ptr=nil
- 1 item -> size=1 ptr=<pointer to item>
- 2-16 items -> size=n ptr=<pointer to array of items>
- >16 -> size=-1 ptr=<pointer to map[T]struct{}>
Should reduce memory usage significantly.
Saves 8 bytes per instance, which can add up in some places.
fasaxc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an "adaptive" implementation of
set.Setthat uses a different storage approach depending on number of items.It is faster and uses a fraction of the RAM for 0-16 items, then its performance becomes similar to the normal set.Typed (with slight overhead).
Use the map in the named port index, where we have many sets that are generally expected to be very small.
It knocks 20% off the
BenchmarkSnapshot200Local250kTotal10000TagPolsbenchmark, which has a very large number of small sets. It gives almost no improvement on the others, but those are dominated by having large numbers of active policies and very few labels.Also included: store sets as their concrete type in the places where we store a lot of them; saves a few MB.
Related issues/PRs
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.