Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust UI disaply of Global, Public, Private #10014

Merged

Conversation

caseydavenport
Copy link
Member

@caseydavenport caseydavenport commented Mar 19, 2025

Description

Related issues/PRs

Mostly to get the discussion going...

We want the UI to show "user facing" values for these cases:

  • No namespace -> "Global"
  • pvt -> "Private Network"
  • pub -> "Public Network"

Todos

  • Tests
  • Documentation
  • Release note

Release Note

TBD

Reminder for the reviewer

Make sure that this PR has the correct labels and milestone set.

Every PR needs one docs-* label.

  • docs-pr-required: This change requires a change to the documentation that has not been completed yet.
  • docs-completed: This change has all necessary documentation completed.
  • docs-not-required: This change has no user-facing impact and requires no docs.

Every PR needs one release-note-* label.

  • release-note-required: This PR has user-facing changes. Most PRs should have this label.
  • release-note-not-required: This PR has no user-facing changes.

Other optional labels:

  • cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.
  • needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.

@caseydavenport caseydavenport requested a review from a team as a code owner March 19, 2025 21:59
@marvin-tigera marvin-tigera added this to the Calico v3.30.0 milestone Mar 19, 2025
@marvin-tigera marvin-tigera added release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Mar 19, 2025
@caseydavenport caseydavenport added docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact labels Mar 19, 2025
@marvin-tigera marvin-tigera removed release-note-required Change has user-facing impact (no matter how small) docs-pr-required Change is not yet documented labels Mar 19, 2025
@caseydavenport caseydavenport merged commit 555f91b into projectcalico:master Mar 29, 2025
3 checks passed
@caseydavenport caseydavenport deleted the casey-adjust-values branch March 29, 2025 00:00
@caseydavenport caseydavenport added cherry-pick-completed PR has been cherry-picked and removed cherry-pick-candidate labels Mar 29, 2025
caseydavenport added a commit that referenced this pull request Mar 31, 2025
…, Private (#10109)

* Adjust UI disaply of Global, Public, Private

* Additional namespace call

* Hints integration

* Add alternative names to filter matching logic in Goldmane
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-completed PR has been cherry-picked docs-not-required Docs not required for this change release-note-not-required Change has no user-facing impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants