-
Notifications
You must be signed in to change notification settings - Fork 256
Remove deprecations #3390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove deprecations #3390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jcoyne
commented
Oct 24, 2024
•
edited
Loading
edited
- Remove FacetFieldListComponent#render_facet_limit_list
- Remove deprecated presenter argument from DocumentComponent#initialize
- Remove deprecated parameters from FacetFieldListComponent
- Remove deprecated SearchContext#blacklisted_search_session_params
- Remove deprecated method CatalogHelperBehavior#current_per_page
- Remove deprecated method ConfigurationHelperBehavior#per_page_options_for_select
- Remove deprecated legacy icons
- Remove deprecate constants
- Remove deprecated helper method #render_document_partials
- Remove deprecated Document::Email and Document::Sms modules
- Remove deprecated arguments from FacetGroupComponent#initialize
49ed5d4
to
123a504
Compare
414dd5a
to
31f4e44
Compare
528dcf6
to
38c353e
Compare
jrochkind
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.