Extract facet presenters and components #2268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeer
force-pushed
the
facet-presenter-view-component
branch
from
acc5039 to
bed12bb
Compare
cbeer
commented
Apr 1, 2020
| @@ -1,5 +1,8 @@ | |||
| # frozen_string_literal: true | |||
| module Blacklight::FacetsHelperBehavior | |||
There was a problem hiding this comment.
It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are:
has_facet_values?(probably not long for this world)render_facet_partials(perhaps part of a future component)render_facet_limit(possibly obsolete once components get traction)facet_field_in_params(a little tricky to deprecate at the moment)facet_field_presenter
jcoyne
approved these changes
Apr 1, 2020
cbeer
force-pushed
the
facet-presenter-view-component
branch
from
261fa84 to
01e0c3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #2168. This PR adds view components for facet fields and facet items, and updates views and helpers to call into the components while preserving backwards compatibility for downstream applications which may have overridden the helpers.
This PR also allows downstream applications to use custom components using a couple new field configuration parameters:
Most of the added code here is to preserve backwards compatibility and can be removed or reshuffled as part of a major release. I've also marked some methods with the
@deprecatedyard tag that I expect to go away as part of another major release (or we can decide to just drop for 8.0), and with@privatefor methods that are only exposed publicly for backwards compatibility.