This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Backend abstraction #236
Merged
Backend abstraction #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-dzon
force-pushed
the
backend-abstraction
branch
3 times, most recently
from
7a44c0f to
d712fed
Compare
|
/test unit-fast |
jordigilh
reviewed
May 27, 2022
jordigilh
reviewed
May 27, 2022
|
Back to draft, as I need to apply a handful of suggestions from @masayag. |
jakub-dzon
force-pushed
the
backend-abstraction
branch
2 times, most recently
from
4b18562 to
8891e25
Compare
masayag
suggested changes
May 31, 2022
jakub-dzon
force-pushed
the
backend-abstraction
branch
from
00cd251 to
7068af9
Compare
masayag
reviewed
May 31, 2022
tupyy
reviewed
Jun 1, 2022
added 18 commits
June 1, 2022 14:24
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Create API definition Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
Signed-off-by: Jakub Dzon <[email protected]>
jakub-dzon
force-pushed
the
backend-abstraction
branch
from
3c65bf3 to
2055fba
Compare
pkliczewski
approved these changes
Jun 1, 2022
jordigilh
reviewed
Jun 1, 2022
jordigilh
approved these changes
Jun 1, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gabriel-farache, jakub-dzon, jordigilh, masayag, pkliczewski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Edge API code to allow us to add another data (EdgeDevice, EdgeWorkload, all of them) source.
New data source (
Backend) should implement theBackendinterface to support current behavior of our Yggdrasil-facing API.Existing data source - CRD-based etcd storage is provided by the
backendstruct. That part should most likely be refactored further to use our generated clients/informers/listers.When more data sources are implemented, the decision on which to use will belong to the
backend.factory- probably based on env variables provided by the user to the flotta-edge-api pod.